Allow to set search_engine version for Users API#140
Merged
lbalmaceda merged 1 commit intomasterfrom Jul 12, 2018
Merged
Conversation
lbalmaceda
commented
Jul 12, 2018
| * Filter by a query | ||
| * | ||
| * @param query the query expression using the following syntax https://auth0.com/docs/api/management/v2/query-string-syntax. | ||
| * @param query the query expression to use |
Contributor
Author
There was a problem hiding this comment.
this filter applies both for Users and Logs. No need to mention the User syntax here.
lbalmaceda
commented
Jul 12, 2018
| */ | ||
| public UserFilter() { | ||
| parameters.put("search_engine", "v2"); | ||
| withSearchEngine("v2"); |
Contributor
Author
There was a problem hiding this comment.
Avoids a breaking change.
lbalmaceda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the search_engine v2 is no longer allowed for new tenants and it's going to be shut down on November 13th this year, this PR adds a setter to specify a different value than the default one.
Fixes #133