Deprecate old list methods that do not support pagination#136
Merged
lbalmaceda merged 1 commit intomasterfrom Jul 12, 2018
Merged
Deprecate old list methods that do not support pagination#136lbalmaceda merged 1 commit intomasterfrom
lbalmaceda merged 1 commit intomasterfrom
Conversation
Member
|
@lbalmaceda can you show clearly in description which methods are being deprecated and their replacement. We should always show Public API changes in description. Thx |
lbalmaceda
force-pushed
the
deprecate-old-list
branch
from
a73eed3 to
dd1b032
Compare
cocojoe
approved these changes
Jul 12, 2018
Member
cocojoe
left a comment
cocojoe
left a comment
There was a problem hiding this comment.
I changed base to the other PR to review, then changed back, looks good.
lbalmaceda
force-pushed
the
deprecate-old-list
branch
from
dd1b032 to
336aec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #135 (merge that one first and rebase).
Closes #134
The following methods are deprecated in favor of alternatives that support Pagination
ClientGrantsEntity#list()ConnectionsEntity#list(ConnectionFilter filter)GrantsEntity#list(String userId)ResourceServerEntity#list()