Add pagination support to Client Grants, Grants, Resource Servers and Rules#132
Merged
lbalmaceda merged 5 commits intomasterfrom Jul 4, 2018
Merged
Add pagination support to Client Grants, Grants, Resource Servers and Rules#132lbalmaceda merged 5 commits intomasterfrom
lbalmaceda merged 5 commits intomasterfrom
Conversation
joshcanhelp
approved these changes
Jul 3, 2018
Contributor
joshcanhelp
left a comment
joshcanhelp
left a comment
There was a problem hiding this comment.
Approved per @cocojoe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds pagination support on MGMT API entities that were missing.
Scope
Discussion
Since the Rules entity already was accepting a Filter as part of the call params, and no other param is required I am forced to create a new method (because the returned type change). This looks odd since the accepted call params are equally the same to the existing
listmethod. If you look carefully, what changes between this one and the rest of the entities is that now I added alistAllmethod to handle pagination on RulesPending items
Deprecate the old
listmethods without pagination.Closed Issues
Closes #126
Related Issues
Related #134