Add Resend verification email functionality by minhlongdo · Pull Request #120 · auth0/auth0-java

minhlongdo · 2018-04-26T18:41:07Z

No description provided.

lbalmaceda · 2018-05-23T17:32:12Z

src/main/java/com/auth0/json/mgmt/jobs/Job.java

+    private String id;
+
+    @JsonCreator
+    public Job(@JsonProperty("status") String status, @JsonProperty("type") String type, @JsonProperty("id") String id) {


I think for the time being, this doesn't need to be public. Can you try making it private or package protected at least? See if Jackson complains.

lbalmaceda · 2018-05-23T17:52:19Z

src/main/java/com/auth0/json/mgmt/jobs/Job.java

+    }
+
+    @JsonProperty("created_at")
+    public void setCreatedAt(String createdAt) {


I don't see any sample values for this created_at field in the api docs. But probably would be better to just use a Date and make Jackson convert between the types. I think the API already makes use of the ISO-8601 format. See the User's class created_at method. If this is the case, then you'll also need to update the JSON samples used in the introduced tests.

lbalmaceda · 2018-05-23T17:56:07Z

src/main/java/com/auth0/client/mgmt/JobsEntity.java

+     * @param recipient the email verification recipient.
+     * @return a Request to execute.
+     */
+    public Request<Job> sendVerificationEmail(EmailRecipient recipient) {


2 parameters seems fine to have them expanded on the signature. Why do you suggest to use this new EmailRecipient class? Maybe it's more straight forward to validate the user id value (non-null) and let the client id one be optional (nullable). Java-docs would clarify each one's validation respectively.

lbalmaceda · 2018-06-07T19:04:44Z

@minhlongdo are you still interested on this?

minhlongdo · 2018-06-07T19:22:38Z

@lbalmaceda Yes, I am looking at it now. Sorry for the delay.

…h0-java into resend-verification-email

…clientId, incl. update tests

…h0-java into resend-verification-email

minhlongdo · 2018-06-07T20:50:21Z

@lbalmaceda could you try to kick off the CI again please? It compiles on my laptop. Thanks! :)

minhlongsmbp2:auth0-java minhlongdo$ ./gradlew test
Using version 1.6.0-SNAPSHOT for auth0
:compileJava UP-TO-DATE
:processResources UP-TO-DATE
:classes UP-TO-DATE
:compileTestJava UP-TO-DATE
:processTestResources UP-TO-DATE
:testClasses UP-TO-DATE
:test UP-TO-DATE

BUILD SUCCESSFUL

Total time: 4.151 secs```

lbalmaceda · 2018-06-07T21:12:01Z

@minhlongdo because we still support JDK 7 you need to change this line https://github.com/auth0/auth0-java/pull/120/files#diff-a5e9c9a379e91d2a7b2790bae000ed6bR35 and cast the second parameter to Object, like we do in many other tests.

assertThat(body, hasEntry("user_id", (Object) "google-oauth2|1234"));

minhlongdo · 2018-06-07T21:14:45Z

@lbalmaceda ok thank you for pointing it out, I am unable to test it with JDK 7 :(

…clientId, incl. update tests

…h0-java into resend-verification-email

minhlongdo · 2018-06-07T21:34:47Z

@lbalmaceda Do you want me to do some squashing?

lbalmaceda · 2018-06-07T21:40:03Z

I'll review this PR again tomorrow. You can squash them if you want or I can do that myself when I merge it. ⚡️

lbalmaceda

I left some final comments. Most of them are just string or docs changes.

lbalmaceda · 2018-06-08T20:57:54Z

src/main/java/com/auth0/client/mgmt/JobsEntity.java

+     * @return a Request to execute.
+     */
+    public Request<Job> sendVerificationEmail(String userId, String clientId) {
+        Asserts.assertNotNull(userId, "recipient");


I get what you mean by recipient, but the parameter is called userId so this exception message is a bit miss-leading. Either change the string in this line to "user id" or clarify in the param's javadoc that the value is the recipient of the email.

lbalmaceda · 2018-06-08T21:02:27Z

src/main/java/com/auth0/client/mgmt/JobsEntity.java

+        CustomRequest<Job> request = new CustomRequest<>(client, url, "POST", new TypeReference<Job>() {
+        });
+        request.addHeader("Authorization", "Bearer " + apiToken);
+        request.setBody((Object) requestBody);


this one doesn't need to be casted to Object.

lbalmaceda · 2018-06-08T21:02:47Z

src/main/java/com/auth0/client/mgmt/ManagementAPI.java

    }
+
+    /**
+     * Getter for Jobs entity.


Getter for the Jobs entity

lbalmaceda · 2018-06-08T21:12:36Z

src/test/java/com/auth0/client/mgmt/JobsEntityTest.java

+
+    @Test
+    public void shouldSendUserAVerificationEmailWithClientId() throws Exception {
+        Request<Job> request = api.jobs().sendVerificationEmail("google-oauth2|1234", "google-oauth2|client-id");


I know this is just a test, but a client id value looks different. Try something similar to AaiyAPdpYdesoKnqjj8HJqRn4T5titww as used in another test please.

lbalmaceda · 2018-06-08T21:13:44Z

src/test/java/com/auth0/client/mgmt/JobsEntityTest.java

+    }
+
+    @Test
+    public void shouldThrowOnNullEmailRecipient() throws Exception {


Depending on what you choose to fix the other comment, this test might need to be renamed.

minhlongdo added 2 commits April 26, 2018 19:24

Add 'Send verification email functionality' with tests

3cc0034

Add documentation

4863f85

minhlongdo changed the title ~~Add Resend verification email functionality #62~~ Add Resend verification email functionality Apr 26, 2018

minhlongdo added 3 commits April 26, 2018 19:45

Cast String to Object

2e5796a

Add tests for deserialization

2c8a6af

Remove setters for required fields

e073168

minhlongdo mentioned this pull request Apr 27, 2018

How to request Auth0 to resend the verification email, via Java API? #62

Closed

lbalmaceda self-requested a review April 27, 2018 14:22

lbalmaceda self-assigned this Apr 27, 2018

Merge branch 'master' into resend-verification-email

9493162

lbalmaceda suggested changes May 23, 2018

View reviewed changes

minhlongdo added 7 commits June 7, 2018 20:25

Make public constructor private

9c0c46f

Merge branch 'resend-verification-email' of github.com:minhlongdo/aut…

91b0982

…h0-java into resend-verification-email

Remove EmailRecipient class and replaced it with userId and optional …

c223179

…clientId, incl. update tests

Remove create_at setter

666f4bd

Merge branch 'master' into resend-verification-email

95e0a4e

Add body size assertion

78c950b

Merge branch 'resend-verification-email' of github.com:minhlongdo/aut…

7dfa12c

…h0-java into resend-verification-email

minhlongdo added 3 commits June 7, 2018 21:52

Map String to Object

915f51f

Cast Map to Object

8e39c7a

Turn Object back to String

39b8d5b

lbalmaceda added 4 commits June 7, 2018 22:15

expose additional error response properties in the exception

aa63893

use unmmodifiable map when possible

754ef0e

add missing test case

fa10b1c

add casting. fixes jdk7 test

58b4d30

minhlongdo and others added 18 commits June 7, 2018 22:15

Remove EmailRecipient class and replaced it with userId and optional …

49415e0

…clientId, incl. update tests

Remove create_at setter

c6f8cb3

Add body size assertion

e5efd70

add email templates endpoints

2d6030a

Add missing email templates entity getter

eae9b5d

add tests and update email-templates entity

cb58911

(: codavaj xif

b51675d

fix class level javadoc

93acdfa

fix test

998c095

change default for syntax. add json tests

1b19583

Release 1.6.0

9d78f6f

Map String to Object

46505b9

Cast Map to Object

bffe90f

Turn Object back to String

eedc230

Cast String to Object in test

ffc37fc

Merge branch 'resend-verification-email' of github.com:minhlongdo/aut…

f334502

…h0-java into resend-verification-email

Cast String to Object in test

edb5877

Add test for scenario when clientId is specified

56173d6

lbalmaceda suggested changes Jun 8, 2018

View reviewed changes

Changes made based on PR comments

8af65bd

lbalmaceda approved these changes Jun 11, 2018

View reviewed changes

lbalmaceda added the CH: Added label Jun 11, 2018

lbalmaceda added this to the v1-Next milestone Jun 11, 2018

lbalmaceda merged commit 3c408c0 into auth0:master Jun 11, 2018

lbalmaceda modified the milestones: v1-Next, 1.7.0 Jun 11, 2018

Conversation

minhlongdo commented Apr 26, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lbalmaceda commented Jun 7, 2018

Uh oh!

minhlongdo commented Jun 7, 2018

Uh oh!

minhlongdo commented Jun 7, 2018

Uh oh!

lbalmaceda commented Jun 7, 2018

Uh oh!

minhlongdo commented Jun 7, 2018

Uh oh!

minhlongdo commented Jun 7, 2018

Uh oh!

lbalmaceda commented Jun 7, 2018

Uh oh!

lbalmaceda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants