Skip to content

Close ResponseBody buffer after read#101

Merged
lbalmaceda merged 1 commit intomasterfrom
fix-buffer-state
Dec 27, 2017
Merged

Close ResponseBody buffer after read#101
lbalmaceda merged 1 commit intomasterfrom
fix-buffer-state

Conversation

@lbalmaceda
Copy link
Copy Markdown
Contributor

Wish I could test this in an easy way but that would require extending OkHttp classes to store the "closed" state.
Will fix #100

@lbalmaceda lbalmaceda added this to the v1-Next milestone Dec 26, 2017
@lbalmaceda lbalmaceda requested a review from cocojoe December 26, 2017 21:15
Copy link
Copy Markdown
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbalmaceda lbalmaceda merged commit 5d83ed8 into master Dec 27, 2017
@lbalmaceda lbalmaceda deleted the fix-buffer-state branch December 27, 2017 12:46
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.5.1 Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connection leakage - during VoidRequest processing its response body wasn't closed

2 participants