Skip to content

Commit 7787168

Browse files
committed
Use global env variable to specify Go version on CI
Signed-off-by: Maksym Pavlenko <[email protected]>
1 parent 1e6523f commit 7787168

3 files changed

Lines changed: 22 additions & 13 deletions

File tree

.github/workflows/ci.yml

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ on:
99
- main
1010
- 'release/**'
1111

12+
env:
13+
# Go version we currently use to build containerd across all CI.
14+
# Note: don't forget to update `Binaries` step, as it contains the matrix of all supported Go versions.
15+
GO_VERSION: '1.18.5'
16+
1217
jobs:
1318
#
1419
# golangci-lint
@@ -20,13 +25,12 @@ jobs:
2025

2126
strategy:
2227
matrix:
23-
go-version: [1.18.5]
2428
os: [ubuntu-18.04, macos-12, windows-2019]
2529

2630
steps:
2731
- uses: actions/setup-go@v2
2832
with:
29-
go-version: ${{ matrix.go-version }}
33+
go-version: ${{ env.GO_VERSION }}
3034

3135
- uses: actions/checkout@v2
3236
- uses: golangci/golangci-lint-action@v3
@@ -46,7 +50,7 @@ jobs:
4650
steps:
4751
- uses: actions/setup-go@v2
4852
with:
49-
go-version: '1.18.5'
53+
go-version: ${{ env.GO_VERSION }}
5054

5155
- uses: actions/checkout@v2
5256
with:
@@ -78,7 +82,7 @@ jobs:
7882
steps:
7983
- uses: actions/setup-go@v2
8084
with:
81-
go-version: '1.18.5'
85+
go-version: ${{ env.GO_VERSION }}
8286

8387
- uses: actions/checkout@v2
8488
with:
@@ -110,7 +114,7 @@ jobs:
110114
steps:
111115
- uses: actions/setup-go@v2
112116
with:
113-
go-version: '1.18.5'
117+
go-version: ${{ env.GO_VERSION }}
114118
- uses: actions/checkout@v2
115119
- run: go install github.com/cpuguy83/go-md2man/[email protected]
116120
- run: make man
@@ -148,7 +152,7 @@ jobs:
148152
steps:
149153
- uses: actions/setup-go@v2
150154
with:
151-
go-version: '1.18.5'
155+
go-version: ${{ env.GO_VERSION }}
152156
- uses: actions/checkout@v2
153157
- run: |
154158
set -e -x
@@ -262,7 +266,7 @@ jobs:
262266
steps:
263267
- uses: actions/setup-go@v2
264268
with:
265-
go-version: '1.18.5'
269+
go-version: ${{ env.GO_VERSION }}
266270

267271
- uses: actions/checkout@v2
268272
with:
@@ -404,7 +408,7 @@ jobs:
404408
steps:
405409
- uses: actions/setup-go@v2
406410
with:
407-
go-version: '1.18.5'
411+
go-version: ${{ env.GO_VERSION }}
408412

409413
- uses: actions/checkout@v2
410414

@@ -534,7 +538,7 @@ jobs:
534538
steps:
535539
- uses: actions/setup-go@v2
536540
with:
537-
go-version: '1.18.5'
541+
go-version: ${{ env.GO_VERSION }}
538542
- uses: actions/checkout@v2
539543
- run: sudo -E PATH=$PATH script/setup/install-gotestsum
540544
- name: Tests

.github/workflows/nightly.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ on:
66
paths:
77
- '.github/workflows/nightly.yml'
88

9+
env:
10+
GO_VERSION: '1.18.5'
11+
912
jobs:
1013
linux:
1114
name: Linux
@@ -18,7 +21,7 @@ jobs:
1821
steps:
1922
- uses: actions/setup-go@v2
2023
with:
21-
go-version: '1.18.5'
24+
go-version: ${{ env.GO_VERSION }}
2225

2326
- uses: actions/checkout@v2
2427
with:
@@ -155,7 +158,7 @@ jobs:
155158
steps:
156159
- uses: actions/setup-go@v2
157160
with:
158-
go-version: '1.18.5'
161+
go-version: ${{ env.GO_VERSION }}
159162

160163
- uses: actions/checkout@v2
161164
with:

.github/workflows/release.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ on:
55

66
name: Containerd Release
77

8+
env:
9+
GO_VERSION: '1.18.5'
10+
811
jobs:
912
check:
1013
name: Check Signed Tag
@@ -66,7 +69,7 @@ jobs:
6669
- name: Install Go
6770
uses: actions/setup-go@v2
6871
with:
69-
go-version: '1.18.5'
72+
go-version: ${{ env.GO_VERSION }}
7073
- name: Set env
7174
shell: bash
7275
env:
@@ -109,7 +112,6 @@ jobs:
109112
find ./releases/ -maxdepth 1 -type l | xargs rm
110113
working-directory: src/github.com/containerd/containerd
111114
env:
112-
GO_VERSION: '1.18.5'
113115
PLATFORM: ${{ matrix.platform }}
114116
- name: Save Artifacts
115117
uses: actions/upload-artifact@v2

0 commit comments

Comments
 (0)