Fix out of bounds memory access when scrolling a spectrogram #9124
Merged
kryksyh merged 2 commits intoaudacity:audacity3from Jul 24, 2025
Merged
Conversation
Accessing data() before the vector was resized is an undefined behavior, causing a crash when ASAN is enabled
kryksyh
force-pushed
the
8851_fix_crash_while_scrolling_a_spectrogram
branch
from
837ceaa to
c4d2737
Compare
saintmatthieu
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #8851
The cache memory region was resized before the old data was moved
Recommended: