build: force benchpress to be compiled with ES2020 (angular#49332)

alan-agius4 · atscott · commit 132c00c2f88f · 2023-03-22T14:00:20.000-07:00
Benchpress requires a decent amount of work to be ES2022 compliant. This will be done in a followup PR. PR Close angular#49332
diff --git a/packages/benchpress/BUILD.bazel b/packages/benchpress/BUILD.bazel
@@ -10,6 +10,9 @@ ts_library(
             "src/**/*.ts",
         ],
     ),
+    # TODO(alanagius) fix benchpress to compile with es2022
+    devmode_target = "es2020",
+    prodmode_target = "es2020",
     deps = [
         "//packages:types",
         "//packages/core",
diff --git a/packages/benchpress/test/BUILD.bazel b/packages/benchpress/test/BUILD.bazel
@@ -4,6 +4,9 @@ ts_library(
     name = "test_lib",
     testonly = True,
     srcs = glob(["**/*.ts"]),
+    # TODO(alanagius) fix benchpress to compile with es2022
+    devmode_target = "es2020",
+    prodmode_target = "es2020",
     deps = [
         "//packages:types",
         "//packages/benchpress",
diff --git a/tools/defaults.bzl b/tools/defaults.bzl
@@ -103,6 +103,8 @@ def ts_library(
         deps = [],
         module_name = None,
         package_name = None,
+        devmode_target = "es2022",
+        prodmode_target = "es2022",
         **kwargs):
     """Default values for ts_library"""
     deps = deps + ["@npm//tslib"]
@@ -122,21 +124,20 @@ def ts_library(
     if not package_name:
         package_name = _default_module_name(testonly)
 
-    default_target = "es2022"
     default_module = "esnext"
 
     _ts_library(
         name = name,
         tsconfig = tsconfig,
         testonly = testonly,
         deps = deps,
-        devmode_target = default_target,
+        devmode_target = devmode_target,
         devmode_module = default_module,
         # For prodmode, the target is set to `ES2022`. `@bazel/typecript` sets `ES2015` by
         # default. Note that this should be in sync with the `ng_module` tsconfig generation.
         # https://github.com/bazelbuild/rules_nodejs/blob/901df3868e3ceda177d3ed181205e8456a5592ea/third_party/github.com/bazelbuild/rules_typescript/internal/common/tsconfig.bzl#L195
         # https://github.com/bazelbuild/rules_nodejs/blob/9b36274dba34204625579463e3da054a9f42cb47/packages/typescript/internal/build_defs.bzl#L85.
-        prodmode_target = default_target,
+        prodmode_target = prodmode_target,
         prodmode_module = default_module,
         # `module_name` is used for AMD module names within emitted JavaScript files.
         module_name = module_name,
