We should update Node: Axosoft/nsfw#82

@DeeDeeG Let me know if you can take a look into updating the Node versions. I think there are two parts to that. One is apm and the other one is the CI version.

I am seeing a build failure for @atom/fuzzy-native.

I think the updates needed for Electron 7/Node 12.4 were posted here: facebook-atom/nuclide-prebuilt-libs#41 (comment)

Apparently @atom/fuzzy-native is a fork of the facebook Atom IDE/nuclide repo's version of fuzzy-native.

Before rushing for another electron upgrade we should update Node everywhere to an identical version.

Quick reminder: Electron 5 is loosely based on Node 12.0.0.

Electron 6 is based on Node 12.4.0. Electron 7 is based on Node 12.8.1.

https://www.electronjs.org/releases/stable?version=7&page=5#release-notes-for-v700

Even in cases that the same version is not necessary, it is much easier to organize this whole thing when we use a single identical Node version. I want to put this PR on hold until we do this.

We have more important things to do before bumping Electron. I don't want to continue with this for now.

Thanks. I am a bit overwhelmed looking at all of the projects, though. Are there any of them in particular that are top priority, or ones where it would be helpful to have another set of eyes on the problem?

@DeeDeeG There are many atom packages outside this list that require updating. You can work on those.

Just leaving this is a note here to ourselves, when upgrading to Electron 7, we can drop the libgconf-2-4 dependency on Debian as we figured out at atom#21422 (comment)

@mfonville Thanks for the note. It may become useful someday.

However, we (community) have many more important things to fix/add before upgrading the electron. The core team might do it instead.

Just out of interest, wouldn't the build error probably be fixed by upgrading NSFW to v1.2.6 (or higher?) https://github.com/Axosoft/nsfw/releases/tag/v1.2.6
They describe it fixes building on Electron 7.1

But maybe v1.2.9 or even v2.0.0 might be a good idea to try? :-)

Yes. That's why we have a pending PR for it 🙂 #76.

If you try this offline, you will also get some errors from fuzzy-native. That one also needs updating.

Now, we have an upstream PR that tracks this https://github.com/atom/atom/pull/21777/files