This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Only add the has-stack class if a detail is present #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UziTech
added a commit
to UziTech/notifications
that referenced
this pull request
Sep 25, 2019
sadick254
approved these changes
May 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Because the stack doesn't get displayed without a detail.
Alternate Designs
Stack could be made independent of detail, but that would require HTML/CSS changes for the notification element.
Benefits
has-stack will only show up when it should now.
Possible Drawbacks
None.
Applicable Issues
Goes hand-in-hand with atom/atom#13821