This repository was archived by the owner on Dec 15, 2022. It is now read-only.
allow cross-compile for ARM, which requires static linking#80
Merged
damieng merged 1 commit intoatom:masterfrom Oct 23, 2017
SteveDesmond-ca:master
Merged
allow cross-compile for ARM, which requires static linking#80damieng merged 1 commit intoatom:masterfrom SteveDesmond-ca:master
damieng merged 1 commit intoatom:masterfrom
SteveDesmond-ca:master
Conversation
Contributor
Author
|
Yay, thanks! Any idea when this will be tagged for release on npm? Would love to be able to bring it into VSCode ASAP. |
Contributor
|
4.0.5 is out. Are there any Atom packages/dependencies that need this bumped for what you're doing? |
Contributor
Author
|
Nope, keytar is a top-level dependency, and I confirmed it cross-compiles successfully now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79
Unfortunately, due to a lower-level linker failure, ARM builds must be compiled as astatic library.
This PR solves that by setting the target type to
static_librarywhentarget_arch=="arm".