This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Bump tree-sitter-ruby to 0.17.0 #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarlemSquirrel
force-pushed
the
tree-sitter-ruby-0.17
branch
from
82204f5 to
32a5c34
Compare
aminya
approved these changes
Nov 12, 2020
|
Would love to get this merged. 👍 |
|
Yeah, I'm waiting for the improvements so bad :) |
Contributor
Author
|
@aminya do you have a few minutes to review this? Thank you! |
aminya
approved these changes
Jan 8, 2021
Contributor
aminya
left a comment
aminya
left a comment
There was a problem hiding this comment.
Looks good to me.
If there are added scopes, we can consider adding those in a different pull request. Here is the changelog for reference.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Bump tree-sitter-ruby to 0.17
Alternate Designs
I do not think there is any viable alternative.
Benefits
This should fix #274 by including fixes from tree-sitter/tree-sitter-ruby#112
Possible Drawbacks
Shouldn't be any.
Applicable Issues
enddoes not get highlighted after a block with a rescue inside a method #274