This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add ERB highlighting inside of script tags #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingrunr21
added a commit
to rubyide/vscode-ruby
that referenced
this pull request
Aug 17, 2019
1 task
Contributor
|
Thanks for the contribution |
Contributor
Author
Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This adds embedded js rules to the grammar for
html.erbfiles so that erb syntax highlighting will work inside of script tags.Alternate Designs
None
Benefits
ERB highlighting will work correctly when placed inside of a script tag.
Before:
After
Possible Drawbacks
None that I am aware of
Applicable Issues
#192 and #230