This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add Signed-off-by line in commit log message. #914
Description
Description
Make possible to add a Signed-off-by line by the committer at the end of the commit log message. Many projects, even hosted in GitHub, needs a signoff line to prove the authorship of the commit.
When running $ git commit -s <file> the default editor is opened to write the commit log message and the Signed-off-by line came inserted automatically.
Expected behavior:
Enable the option to signoff the commit, by a selectiong a check box on UI near the "Commit" button (like the "Amend" option), and then have the Signed-off-by: <committer-email> line in the end of the field "Commit message".
Actual behavior:
No option to signoff a commit.
Reproduces how often:
100% of the time I want commit using github package.
Versions
OS: Linux, Fedora 25
$ atom-beta --version
Atom : 1.18.0-beta2
Electron: 1.3.15
Chrome : 52.0.2743.82
Node : 6.5.0
$ apm-beta --version
apm 1.18.1
npm 3.10.10
node 6.9.5 x64
python 2.7.13
git 2.9.4
Reacted by Nick, kfrz, Matthieu Baerts, Chris Fung, Sergio Durand, Paulo Vital, Erwan Gouriou, Ahmed Shawky, JamesKingdon, Claudius Ellsel and 7 more
Activity
kfrz commentedon Jun 17, 2017
mikebrow commentedon Aug 30, 2017
lnxg33k commentedon Oct 25, 2017
Arcanemagus commentedon Oct 25, 2017
claell commentedon Jun 13, 2018
@Arcanemagus
The problem is I don't know how to tell it to git in the config. There does not seem to be a setting for that, right?
Arcanemagus commentedon Jun 13, 2018
@claell Reading your comments in the linked issue, you are talking about the issue in this PR (using
--signoff). My comment was about GPG signing your commits, which is an entirely different subject.Note that that project seems to be misunderstanding the usage of
--signoff, but it's a common misconception.gitonly provides a method for automatically adding--signofffor patches, since that is the intent:format.signoffclaell commentedon Jun 13, 2018
Ah sorry. Thought the last sentence of your comment was about the signoff again and not the GPG signing.
I did not find much confirmation on the link to stackoverflow you provided that the intent is only for patches, not for commits.
mikebrow commentedon Jun 18, 2018
Not sure why my comment was marked as off-topic. Signing a commit using the lowercase "-s" to inject your signed off by email in a commit is a ubiquitous use of github. Just about every major github project requires this. Thus this feature not being available in Atom forces users of Atom to commit outside the editor, making commit in the editor pretty much a useless feature. The importance of this feature was not specified in the issue. There is no feature in git for automatically signing (-s) commits. If a user accidentally uses Atom to commit they will have to amend their commit by signing it outside Atom and force pushing the amended commit.