This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
Contributor
|
We are interested in taking this feature. We need two modifications first:
Once that's done, we'll take a deeper look. Thanks for the submission! |
* master: Decaffeinate lib/path-loader.coffee 🎨 Use fat arrow function syntax 👕 Remove unused assignment 👕 Remove unused assignment Decaffeinate spec/fuzzy-finder-spec.coffee Remove obsolete shim for atom.workspace.getCenter() Decaffeinate lib/main.coffee Decaffeinate lib/load-paths-handler.js Decaffeinate lib/helpers.coffee Decaffeinate lib/file-icons.coffee Decaffeinate lib/default-file-icons.coffee
ColCh
force-pushed
the
prefill-from-selection
branch
from
28a83de to
f2159c8
Compare
Contributor
Author
|
Done. Now this behaviour is turned on by config variable. Please review, ping @lee-dohm |
Contributor
|
👍 Works like a charm. Thanks for the contribution! 🎉 |
Contributor
Author
|
@smashwilson great! Thank you! |
This was referenced Jan 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
When you select text, then activate fuzzy-finder, it will look for selection in active editor.
If there is some text selected, it will use it as query - and select text inside of query as well
Alternate Designs
Didn't noticed any. Only in Nuclide's
nuclide-quick-openthere is analogue for it, but you can't use it without installing entirenuclidepackageBenefits
Now you don't need to Copy-Paste your selection in fuzzy finder.
This speedups programming performance :)
Possible Drawbacks
May be opened a bit* slowly, because it looks for editor selected text
Applicable Issues
resolves #161