This repository was archived by the owner on Mar 3, 2023. It is now read-only.
bootstrap: Update Node requirement to 10.12+ in system requirement checker #23001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Node 10.12 or newer" has been a hard requirement since this PR: atom#20879, due to newer versions of electron-chromedriver and electron-mksnapshot relying on extract-zip@2 as an indirect dependency. (extract-zip@2 requires Node 10.12 or newer for its recursive mkdir. Using extract-zip@2 with Node older than 10.12 results in errors. That leads to a lack of electron-vendored chromedriver or mksnapshot binaries where they're supposed to be. Which in turn causes startup blob creation (via mksnapshot) to fail toward the end of the Atom build scripts.)
Contributor
|
Thanks for the contribution 🙇🏾 @DeeDeeG |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix (from template, click to expand)
Identify the Bug
Companion PR to #22979.
Description of the Change
catchsyntax (support older Node) #22979 is merged without this, users of Node < 10.12 won't be properly warned that their version of Node is too old to properly build Atom.Alternate Designs
I suppose we could hard require Node 10.12+, but "deprecate" anything less than currently, officially upstream-supported Node versions? (12.x is the oldest Node still supported by the Node maintainers as of my writing this. See: https://nodejs.org/en/about/releases/).
(I considered not updating the required Node, but the build script errors out with older Node, so it's not a useful check if we don't update it to 10.12+. I do think Node 10.12+ is the sensible minimum requirement now.)
Possible Drawbacks
Atom might be somewhat functional without a
chromedriverbinary, or without a startup cache? In which case this PR makes it harder to "mostly" build Atom on certain legacy or exotic OSes that we already don't support.Verification Process
I ran
script/build --ciwith Node 9, Node 10.11, and Node 10.12.extract-zip@2using therecursiveoption withfs.mkdir, which is only supported in Node 10.12 or newer, and can silently fail on older Node, leading to "file exists" errors in those older versions of Node.Release Notes
N/A