This repository was archived by the owner on Mar 3, 2023. It is now read-only.
document.registerElement polyfil #22901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atom is upgrading to use electron 11.4.7 however on that version chromium has deprecated `document.registerElement`. There are some community packages whose implementations depend on `document.registerElement`. Therefore shipping without a polyfill will break those packages. As Atom maintainers we wouldn't want to introduce a change that has the potential of breaking many packages.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atom is upgrading to use electron 11.4.7 however on that version
chromium has deprecated
document.registerElement.There are some community packages whose implementations depend on
document.registerElement. Therefore shipping without a polyfill willbreak those packages.
As Atom maintainers we wouldn't want to introduce a change
that has the potential of breaking many packages.