Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Conversation

@mfonville
Copy link
Contributor

Use Ubuntu 18.04 instead of the latest for highest glibc compatibility
Remove rpm workaround as it is not necessary anymore

Copy link
Contributor

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍

I tested installing Atom in VirtualBox, built on either Ubuntu 18.04 or 20.04, and upgrading to building on Ubuntu 18.04 appears to have minimal if any impact on backward-compatibility for Atom users. (Which was a surprise to me.) ubuntu-latest (Ubuntu 20.04) did cause some backward-compatibility issues on older Debian/Ubuntu, though.)

  • Atom built on Ubuntu 18.04 (build artifacts) can still run on Debian 9 and Ubuntu 16.04 ✔️
  • Atom built on ubuntu-latest (Ubuntu 20.04) (build artifacts) won't run on Debian 9 or Ubuntu 16.04 ❌

So I think it's good to stick with building on Ubuntu 18.04 for now.

(Debian 9 is still in LTS support, so I think it's good for Atom to still be able to run there.)

As the Ubuntu 16.04 build environment won't be available in Azure Pipelines after September, we have to upgrade eventually. So, might as well do it now rather than later, especially since there's no obvious downside in my testing.

(P.S. Sorry for all the noise earlier, I had assumed based on general past experience there would be an issue, without confirming it specifically for Atom on these OS versions. The glibc version is newer in Ubuntu 18.04, but apparently not different enough from the glibc in Ubuntu 16.04 or Debian 9 to introduce breaking incompatibility.)

@sadick254 sadick254 merged commit b074765 into atom:migrate-to-ubuntu-latest Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants