This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Bump async dependency to 3.2.0 in /script
#22652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update lockfileVersion to *2*, but that's a side affect from npm https://github.com/caolan/async/blob/master/CHANGELOG.md#v200 v2.0.0 allows importing functions modularily. So I changed the code to only import the functions needed instead of the whole thing.
icecream17
changed the title
async dependency to 3.2.0 in atom/scriptasync dependency to 3.2.0 in /script
Contributor
Author
|
Undrafting, but that pane spec test is at it again. |
Contributor
|
Make sure you are using npm version |
sadick254
approved these changes
Jul 2, 2021
Contributor
sadick254
left a comment
sadick254
left a comment
There was a problem hiding this comment.
Looks great. Thanks for bumping async
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Bumps the
asyncdependency to 3.2.0As a side affect the package-lock's lockfileVersion is now 2, since I'm using a newer npm version. Hopefully that's not importanthttps://github.com/caolan/async/blob/master/CHANGELOG.md#v200
v2.0.0 allows importing functions modularily (instead of importing the whole thing)
Somehow each file involved only needs 1 function, so now the imports only import whatever function is needed
Alternate Designs
Maybe I could just bump the version only without making the modularity change. But it seems to improve things
Possible Drawbacks
None