This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Recreate #15175 #22541
Merged
Recreate #15175 #22541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadick254
reviewed
Jun 4, 2021
Contributor
sadick254
left a comment
sadick254
left a comment
There was a problem hiding this comment.
The changes look good. Do we know what events that lead to the error?
Contributor
Author
|
From what I gather about #15172 we don't know why the error happened. This just adds a console.error handler |
Contributor
|
I think a good approach would be to display the error as a notification. This way we can have visibility when the error occurs. A user will be able to create an issue from the notification modal. See https://flight-manual.atom.io/api/v1.57.0/NotificationManager/ |
I'm assuming that `addError` displays an error. I'm also logging the error on the console - for theoretical debugging in case the notification is dismissed - but maybe it's unnecessary. I renamed `event` to `error` in the `onupgradeneeded` handler
Contributor
Author
|
Is the console.error unnecessary now that there's a notification? |
Contributor
|
The |
Contributor
|
I think |
sadick254
suggested changes
Jun 4, 2021
Co-authored-by: Sadick <[email protected]>
Co-authored-by: Sadick <[email protected]>
sadick254
approved these changes
Jun 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15175
Resolves #15172 (although it's already closed anyways)