Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

⬆️ Bump language-css to 0.44.5 #21963

Closed
DeeDeeG wants to merge 2 commits into from
Closed

⬆️ Bump language-css to 0.44.5 #21963

DeeDeeG wants to merge 2 commits into from

Conversation

@DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Feb 14, 2021

Requirements for Contributing a Bug Fix

Identify the Bug

Closes: #21954

Closes: #21955
(This PR is a re-do of #21955)

Description of the Change

Bumping version of language-css from 0.44.4 to 0.44.5

This includes changes that should fix atom/language-sass#226

Alternate Designs

None.

Possible Drawbacks

None.

Verification Process

CI should pass.

Release Notes

⬆️ language-css 0.44.5 (fixes some incorrect code highlighting)

@DeeDeeG DeeDeeG mentioned this pull request Feb 14, 2021
Closed
@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Feb 14, 2021 •
edited
Loading

I'm seeing this error:

CSS property name and value autocompletions
  SASS files
    pseudo selectors
      it CSS property name and value autocompletions SASS files pseudo selectors autocompletes without a prefix
        TypeError: Cannot read property 'length' of null
          at jasmine.Spec.<anonymous> (/Users/runner/work/1/s/node_modules/autocomplete-css/spec/provider-spec.coffee:903:28)
          at jasmine.Spec.args.<computed> (/Users/runner/work/1/s/spec/jasmine-test-runner.coffee:89:27)

If anyone knows how to solve it, that would be much appreciated.

CI link that jumps to the error

@DeeDeeG DeeDeeG marked this pull request as draft February 15, 2021 04:03
@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Feb 15, 2021

Here's the failing line of the failing test in autocomplete-css:

https://github.com/atom/autocomplete-css/blob/v0.17.5/spec/provider-spec.coffee#L903

@DeeDeeG DeeDeeG mentioned this pull request Feb 20, 2021
Merged
@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Feb 20, 2021

I found the cause of the test failure. This PR in language-css broke the autocomplete-css test: atom/language-css#127

@sadick254
Copy link
Contributor

sadick254 commented Sep 6, 2021

I am closing this PR we now have #22931.

@sadick254 sadick254 closed this Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please update language-css core package version Color for 'cursor' for sass (SCSS) is wrong

3 participants

@DeeDeeG @sadick254 @cssinate