This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Backport macOS startup and shutdown fixes to Atom 1.55 #21948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🍎 Don't quit on 'window-all-closed' on macOS This prevents a lot of buggy partial-quitting stuff from happening. Fixes: atom#17672 Fixes: atom#20831 (cherry picked from commit 72709dc) Co-authored-by: Benjamin Gray <[email protected]>
…rotect (atom#21861) macOS Gatekeeper adds a flag ("-psn_0_[six or seven digits here]") when it intercepts Atom launches. This happens for fresh downloads, new installs, or first launches after upgrading). We don't need this flag, and yargs interprets it as many short flags. So, we filter it out. (cherry picked from commit 7928a1b)
sadick254
approved these changes
Feb 10, 2021
Contributor
sadick254
left a comment
sadick254
left a comment
There was a problem hiding this comment.
Happy with the backports. 👍
Contributor
Author
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix
Identify the Bug
Fixes: #17672 (for Atom 1.55)
Fixes: #20831 (for Atom 1.55)
and
Fixes: #21013 (probably) (for Atom 1.55)
Fixes: #21751 (for Atom 1.55)
Fixes: #21820 (for Atom 1.55)
Description of the Change
Backport the fixes from #21847 and #21861 to Atom 1.55 (currently the Beta channel, expected to become stable soon).
These are very noticeable bugs that continue to confuse users of Atom stable and Beta on macOS at the moment. It might be worthwhile to backport these fixes.
Alternate Designs
We could just wait for Atom 1.56 to reach Beta and Stable, but that could take about a month longer.
Possible Drawbacks
None.
Verification Process
CI run at my fork for this PR. (Still running.)
(This has been in Nightly for a while and is working well.)
See the original PRs for more details.
Release Notes
Fix buggy launching and quitting for certain situations on macOS.