Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Conversation

@smashwilson
Copy link
Contributor

GitHub package upgrade. 🤞🏻

cc @DeeDeeG who has been working tirelessly to get these builds working!

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Jan 29, 2021

I think the failure here is unrelated.

I've seen this flake out on a number of different PRs:

Dock
  when a dock is activated
    it Dock when a dock is activated opens the dock and activates its active pane
      Expected HTMLNode to be HTMLNode.
        at jasmine.Spec.<anonymous> (file:///D:/a/1/s/spec/dock-spec.js:18:38)
        at jasmine.Spec.args.<computed> (file:///D:/a/1/s/spec/jasmine-test-runner.coffee:89:27)

...

##[error] The 'core-render-process in D:/a/1/s/spec/dock-spec.js.' test step finished with a non-zero exit code 
 You can run the test again using: 
	 D:/a/1/s/out/Atom Dev x64/atom-dev.exe --resource-path D:\a\1\s --test D:/a/1/s/spec/dock-spec.js

I'm sure there's more to those two HTMLNodes but the error logger doesn't seem to want to print all of it.

@smashwilson
Copy link
Contributor Author

Yah, re-running.

@smashwilson
Copy link
Contributor Author

🎉

@smashwilson smashwilson marked this pull request as ready for review January 29, 2021 13:55
@smashwilson smashwilson merged commit 1f9e0c0 into master Jan 29, 2021
@smashwilson smashwilson deleted the github-up-dev branch January 29, 2021 13:55
This was referenced Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants