Clip cursor width when soft-wrap is on and cursor is at the end of a line #16943
Conversation
This prevents the parent tile from disabling sub-pixel anti-aliasing. For some reason, adding `overflow: hidden` to the cursor container element doesn't solve the issue, so we're adding this workaround instead.
|
@as-cii I can still reproduce this issue when the cursor is on the very edge of the window. Before: After: |
|
Possibly unrelated but I also noticed that changing tabs when the cursor is in this position causes the editor to scroll horizontally:
|
|
@Ben3eeE thanks for the feedback! 💯 We should pair on this sometime, as I can't reproduce the problem anymore on my machine unfortunately. |
|
@as-cii What do you think about merging this for now but not closing the issue? This PR does make it a lot better and the issue I mentioned in #16943 (comment) can be reproduced on master so it's unrelated to this PR. I'm up for pairing to fix these two issues. |
|
Sounds good, thanks for the feedback @Ben3eeE! Can you open a separate issue describing the problem? |
Description of the Change
This pull request prevents the parent tile from disabling sub-pixel anti-aliasing by clipping the cursor width to be fully contained within the editor when soft-wrap is on and the cursor is at the end of a line. For some reason, adding
overflow: hiddento the cursor container element doesn't solve the issue, so we're adding this workaround instead.Alternate Designs
Unclear.
Verification Process
Applicable Issues
Fixes #16889
/cc: @Ben3eeE @50Wliu can you confirm this pull request fixes it? Thanks! 🙇