This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Make ContextMenu async #16192
Merged
Make ContextMenu async #16192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Follow-up issues:
|
This was referenced Nov 15, 2017
winstliu
force-pushed
the
wl-async-context-menu
branch
from
8a81c9f to
a59913f
Compare
Contributor
|
/cc @BinaryMuse to review |
Contributor
|
The concern I had about the right-click hijacking hack in the GitHub package appears to be fine with this change. 👍 to merge once it's green! |
1 task
1 task
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Makes the context menu async, which is important for perceived performance and UX. No longer will everything freeze when opening a context menu. Here's a gif of snowfall!
Alternate Designs
None.
Why Should This Be In Core?
Context menu handling occurs in the main process.
Benefits
Context menus no longer block the renderer process until they are closed.
Possible Drawbacks
Per electron/electron#9441 it is not possible to detect when the context menu is closed. Atom currently does not track context menu state so I think this compromise is fine.
Applicable Issues
Supersedes and closes #13398
Fixes #2991
Refs #13617, though it looks like right-click isn't properly focusing the tab so more investigation will be needed.