Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Add custom start tiles #15975

Merged
sadick254 merged 7 commits into from
Sep 1, 2021
Merged

Add custom start tiles #15975

sadick254 merged 7 commits into from
Sep 1, 2021

Conversation

@richiksc
Copy link
Contributor

@richiksc richiksc commented Oct 23, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Add Windows 10-style Atom start tiles, which look like this:
Large Windows 10 start tile
Small Windows 10 start tile

Alternate Designs

The monogram icon on a solid color background follows other Windows 10 apps the best.

Why Should This Be In Core?

To bring a pleasant experience to all Windows 10 users using Atom pinned to start.

Benefits

Atom users on Windows 10 will get proper start tiles.

Possible Drawbacks

People will lose their old default Atom start tile.

Applicable Issues

May not go into directory where atom.exe is stored, because I do not understand Atom's build system.

@Ben3eeE Ben3eeE added needs-review windows Issues that occur on Windows but not on other platforms. labels Oct 24, 2017
@richiksc
Copy link
Contributor Author

richiksc commented Oct 27, 2017

I need to include Hi-DPI assets as well.

praveeno
praveeno suggested changes Nov 30, 2017
View reviewed changes
Copy link

@praveeno praveeno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add HDPI image for big screen

@winstliu
Copy link
Contributor

winstliu commented Dec 3, 2017

atom-start-tile
For comparison, here's the current pinned Atom tile.

@simurai
Copy link
Contributor

simurai commented Dec 8, 2017

Looks great! ✨

Would it be possible to have a different background color for stable, beta, dev version? So you could still tell which is which? Probably needs 3 visualElementsManifest.xml files and then include the right one?

@richiksc
Copy link
Contributor Author

richiksc commented Jun 7, 2018

@simurai Right. What colors are you thinking?

@richiksc
Copy link
Contributor Author

richiksc commented Jun 7, 2018 •
edited
Loading

@simurai @50Wliu @praveeno I've added the HiDPI assets and a list view tile.

@simurai
Copy link
Contributor

simurai commented Jun 28, 2018

What colors are you thinking?

There probably will be a 4th "nightly" channel that is purple: #17538 (comment). So how about this:

  • #5FB57D Stable
  • #E0B447 Beta
  • #9142C5 Nightly
  • #74B7E3 Dev

screen shot 2018-06-28 at 1 57 56 pm

Note: I somewhat "randomly" color-picked it from the gradient. 😬

@richiksc
Copy link
Contributor Author

richiksc commented Oct 3, 2018

@simurai Do you know how I would have separate atom.visualElementsManifest.xml files for each channel? I wouldn't be able to modify the background color without it.

@simurai
Copy link
Contributor

simurai commented Oct 6, 2018

Do you know how I would have separate atom.visualElementsManifest.xml files for each channel? I wouldn't be able to modify the background color without it.

No idea. 🤔 If not possible, maybe just have green for all channels?

Yvonne1952-1959
Yvonne1952-1959 approved these changes Jun 7, 2021
View reviewed changes
Copy link

@Yvonne1952-1959 Yvonne1952-1959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resources/win/atom.visualElementsManifest.xml

@icecream17
Copy link
Contributor

icecream17 commented Jun 7, 2021 •
edited
Loading

That spam approval was helpful because I got notified for it. Interesting.

This reminds me of #22123 - although I also don't know enough about atom's file structure to know where the put those files.

@sadick254 sadick254 merged commit 9c6d69f into atom:master Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@praveeno praveeno praveeno requested changes

@kutluhanazafli kutluhanazafli kutluhanazafli approved these changes

@Yvonne1952-1959 Yvonne1952-1959 Yvonne1952-1959 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-review windows Issues that occur on Windows but not on other platforms.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@richiksc @winstliu @simurai @icecream17 @praveeno @kutluhanazafli @Yvonne1952-1959 @Ben3eeE @sadick254