Adding Nemo context menu entry fails #25294
Description
Prerequisites
* [X] Reproduced the problem in Safe Mode: <https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode>
* [X] Followed all applicable steps in the debugging guide: <https://flight-manual.atom.io/hacking-atom/sections/debugging/>
* [X] Checked the FAQs on the message board for common solutions: <https://discuss.atom.io/c/faq>
* [X] Checked that your issue isn't already filed: <https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom>
* [X] Checked that there is not already an Atom package that provides the described functionality: <https://atom.io/packages>
Description
Upon launching atom from command line, the following error is raised:
$ atom test.txt
cp: cannot stat 'resources/linux/desktopenviroment/cinnamon/atom.nemo_action': No such file or directorySteps to Reproduce
- Launch atom from command line.
Note that this applies to any variation of the atom launch command, i.e. atom, atom testfile, atom --safe, atom --safe testfile.
Expected behavior:
Atom should launch without warnings or errors.
Actual behavior:
Atom launches, but previously raises this error message.
$ atom test.txt
cp: cannot stat 'resources/linux/desktopenviroment/cinnamon/atom.nemo_action': No such file or directoryReproduces how often:
Everytime, persistent
Versions
$ atom --version
Atom : 1.60.0
Electron: 9.4.4
Chrome : 83.0.4103.122
Node : 12.14.1
$ apm --version
apm 2.6.2
npm 6.14.13
node 12.14.1 x64
atom 1.60.0
python 2.7.18
git 2.35.1
$ lsb_release -a
No LSB modules are available.
Distributor ID: Linuxmint
Description: Linux Mint 20.3
Release: 20.3
Codename: una
Additional Information
This behavior is related to PR #13414, which introduced lines 171-174 in the atom.shfile. The enclosing if-statement results in this issue only applying to linux-systems with the cinnamon desktop evirnment.
The PR is intended to add a context menu item for atom in nemo within the cinnamon desktop environment. However, this already possible without any modification, as nicely pointed out in the PR by @catscarlet.
As far as I can diagnose it, the atom.sh script cannot locate the atom.nemo_action file when not runnig from source, probably, because it is missing the base path for the atom installation.
In this context, I would suggest to revoke the changes from PR #13414 and remove the newly introduced lines from the atom.sh script.