Make UADA work with __array_ufunc__ #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of xarray and numpy work with __array_ufunc__ nowadays. Make sure this is supported by UADA to keep up to date.
gerritholl
added a commit
to gerritholl/typhon
that referenced
this pull request
Apr 5, 2018
Since commit c6ea042 (merged in atmtools#143), UnitsAwareDataArray depends on xarray.DataArray.__array_ufunc__ (which in turn depends on numpy 1.13 or newer). This was merged into xarray in pydata/xarray#1962 and added to release 0.10.2. The old UnitsAwareDataArray does not work with xarray>=0.10.2 and the new one does not work with xarray<=0.10.1. Therefore, typhon now depends on xarray>=0.10.2 and numpy>=1.13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of xarray and numpy work with array_ufunc nowadays. Make sure
this is supported by UADA to keep up to date.