feat: adding multiple matching mechanism#73
Merged
Conversation
Allow query datasets with multiple keywords using AND logic
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 344 351 +7
=========================================
+ Hits 344 351 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zlmarshall
approved these changes
Nov 18, 2025
Contributor
zlmarshall
left a comment
zlmarshall
left a comment
There was a problem hiding this comment.
Damn, that was fast! This looks great to me. As far as I'm concerned, good to go!
marianaiv
approved these changes
Nov 18, 2025
Contributor
marianaiv
left a comment
marianaiv
left a comment
There was a problem hiding this comment.
Looks good to me. I am just wondering if at some point we should have a fancier search option, because maybe someone will want to look for datasets with one or the other keyword, for example.
In any case, we can have this for now, I think it is really nice :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow query datasets with multiple keywords using AND logic