Skip to content

Mix: code coverage, tests, and bumping python versions#43

Merged
zlmarshall merged 4 commits into
mainfrom
gguerrie-codecov
Aug 19, 2025
Merged

Mix: code coverage, tests, and bumping python versions#43
zlmarshall merged 4 commits into
mainfrom
gguerrie-codecov

Conversation

@Soap2G
Copy link
Copy Markdown
Contributor

@Soap2G Soap2G commented Aug 18, 2025

Related to #26
Closes #40

Major

  • Built test for most of the functions not covered before (we went from ~56% coverage to ~96%).
  • Fixed some logic thanks to the new tests.
    • @zlmarshall have a look to a small edit to match_metadata(), and let me know if it makes any sense.

Minor

  • Updated matrix to 3.9-3.12
  • Set base python version to 3.9

@Soap2G Soap2G requested review from marianaiv and zlmarshall August 18, 2025 10:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 18, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Soap2G Soap2G self-assigned this Aug 18, 2025
@Soap2G Soap2G added the enhancement New feature or request label Aug 18, 2025
Comment thread atlasopenmagic/metadata.py
Comment thread atlasopenmagic/metadata.py Outdated
Copy link
Copy Markdown
Contributor

@zlmarshall zlmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thank you! Just a handful of questions and comments.

Comment thread .github/workflows/test.yml Outdated
Comment thread atlasopenmagic/metadata.py Outdated
Comment thread atlasopenmagic/metadata.py Outdated
Comment thread atlasopenmagic/metadata.py
Comment thread atlasopenmagic/metadata.py
Comment thread pyproject.toml
Copy link
Copy Markdown
Contributor

@zlmarshall zlmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all the updates, looks great as far as I'm concerned!

@zlmarshall zlmarshall merged commit e62c087 into main Aug 19, 2025
7 checks passed
@zlmarshall zlmarshall deleted the gguerrie-codecov branch August 19, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raise minimum Python version to 3.9

2 participants