Merged
Conversation
Allow generation of unreachable code locally Fix gaps in `clock` coverage
Blacksmoke16
added
component:framework
component:validator
component:console
component:event-dispatcher
component:negotiation
component:routing
kind:enhancement
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Flags with carried forward coverage won't be shown. Click here to find out more.
📢 Thoughts on this report? Let us know! |
Blacksmoke16
added
kind:bug
PallasAthenaie
pushed a commit
to athena-framework/clock
that referenced
this pull request
Jan 20, 2025
* Breaking: Rename `ACON::Completion::Input#must_suggest_values_for?` to `#must_suggest_option_values_for?` to better describe what it does * Clear component `coverage/` dir when running coverage specs for that component * Include `spec/` directories in code coverage reporting to allow capturing duplicate named spec methods * Fix typing of `#now` and `#clock=` for `Athena::Clock::Aware` * Fix various methods that were failing once they started being used * Improve test coverage in most components
PallasAthenaie
pushed a commit
to athena-framework/console
that referenced
this pull request
Jan 20, 2025
* Breaking: Rename `ACON::Completion::Input#must_suggest_values_for?` to `#must_suggest_option_values_for?` to better describe what it does * Clear component `coverage/` dir when running coverage specs for that component * Include `spec/` directories in code coverage reporting to allow capturing duplicate named spec methods * Fix typing of `#now` and `#clock=` for `Athena::Clock::Aware` * Fix various methods that were failing once they started being used * Improve test coverage in most components
PallasAthenaie
pushed a commit
to athena-framework/event-dispatcher
that referenced
this pull request
Jan 20, 2025
* Breaking: Rename `ACON::Completion::Input#must_suggest_values_for?` to `#must_suggest_option_values_for?` to better describe what it does * Clear component `coverage/` dir when running coverage specs for that component * Include `spec/` directories in code coverage reporting to allow capturing duplicate named spec methods * Fix typing of `#now` and `#clock=` for `Athena::Clock::Aware` * Fix various methods that were failing once they started being used * Improve test coverage in most components
PallasAthenaie
pushed a commit
to athena-framework/image-size
that referenced
this pull request
Jan 20, 2025
* Breaking: Rename `ACON::Completion::Input#must_suggest_values_for?` to `#must_suggest_option_values_for?` to better describe what it does * Clear component `coverage/` dir when running coverage specs for that component * Include `spec/` directories in code coverage reporting to allow capturing duplicate named spec methods * Fix typing of `#now` and `#clock=` for `Athena::Clock::Aware` * Fix various methods that were failing once they started being used * Improve test coverage in most components
PallasAthenaie
pushed a commit
to athena-framework/framework
that referenced
this pull request
Jan 20, 2025
* Breaking: Rename `ACON::Completion::Input#must_suggest_values_for?` to `#must_suggest_option_values_for?` to better describe what it does * Clear component `coverage/` dir when running coverage specs for that component * Include `spec/` directories in code coverage reporting to allow capturing duplicate named spec methods * Fix typing of `#now` and `#clock=` for `Athena::Clock::Aware` * Fix various methods that were failing once they started being used * Improve test coverage in most components
PallasAthenaie
pushed a commit
to athena-framework/mercure
that referenced
this pull request
Jan 20, 2025
* Breaking: Rename `ACON::Completion::Input#must_suggest_values_for?` to `#must_suggest_option_values_for?` to better describe what it does * Clear component `coverage/` dir when running coverage specs for that component * Include `spec/` directories in code coverage reporting to allow capturing duplicate named spec methods * Fix typing of `#now` and `#clock=` for `Athena::Clock::Aware` * Fix various methods that were failing once they started being used * Improve test coverage in most components
PallasAthenaie
pushed a commit
to athena-framework/negotiation
that referenced
this pull request
Jan 20, 2025
* Breaking: Rename `ACON::Completion::Input#must_suggest_values_for?` to `#must_suggest_option_values_for?` to better describe what it does * Clear component `coverage/` dir when running coverage specs for that component * Include `spec/` directories in code coverage reporting to allow capturing duplicate named spec methods * Fix typing of `#now` and `#clock=` for `Athena::Clock::Aware` * Fix various methods that were failing once they started being used * Improve test coverage in most components
PallasAthenaie
pushed a commit
to athena-framework/routing
that referenced
this pull request
Jan 20, 2025
* Breaking: Rename `ACON::Completion::Input#must_suggest_values_for?` to `#must_suggest_option_values_for?` to better describe what it does * Clear component `coverage/` dir when running coverage specs for that component * Include `spec/` directories in code coverage reporting to allow capturing duplicate named spec methods * Fix typing of `#now` and `#clock=` for `Athena::Clock::Aware` * Fix various methods that were failing once they started being used * Improve test coverage in most components
PallasAthenaie
pushed a commit
to athena-framework/validator
that referenced
this pull request
Jan 20, 2025
* Breaking: Rename `ACON::Completion::Input#must_suggest_values_for?` to `#must_suggest_option_values_for?` to better describe what it does * Clear component `coverage/` dir when running coverage specs for that component * Include `spec/` directories in code coverage reporting to allow capturing duplicate named spec methods * Fix typing of `#now` and `#clock=` for `Athena::Clock::Aware` * Fix various methods that were failing once they started being used * Improve test coverage in most components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
As primarily a one person developer, I rely heavily on Athena's test suite to ensure things are working as expected as I make changes. The recent push to better integrate code coverage reporting is a direct result of this.
This PR makes some minor tweaks to how coverage is handled locally and does a pass on the methods flagged via
crystal tool unreachable, fixing a fair amount of holes in Athena's test coverage and fixes several bugs as a result.Changelog
ACON::Completion::Input#must_suggest_values_for?toACON::Completion::Input#must_suggest_option_values_for?to better describe what it doescoverage/dir when running coverage specs for that componentspec/directories in code coverage reporting to allow capturing duplicate named spec methods#nowand#clock=forAthena::Clock::AwareBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title