Merged
Conversation
Blacksmoke16
added
component:console
kind:feature
Rename types to reduce nesting
Make Cell and TableSeperator classes First table specs
Move table fixtures into dedicated sub dir More specs Handle empty tables, rows, and headers
Fix typo in a type/vars Some additional specs
Add desc to each test case and add one that has both row and colspan
Allow using a 1D array for headers
Various polish More specs
Fix issue with missing headers for a row
Fix lint issues
Remove instances of missing `ACON::Formatter::Mode` type More specs
Change `Enumerable` to `Indexable` Add specs for previously unused table methods
Add implementation +specs for Athena style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_and_wrapis passednilACON::Formatter::Mode#tablemethod to the Style interface