-
-
Notifications
You must be signed in to change notification settings - Fork 3
BSListGroup<TItem, TOwner> and BSListGroupItem<TOwner> components #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Update 1st code for Accordion Bootstrap. I don't figure out the reason why Accordion's links wouldn't be clicked in a row in test. Only 1st link(AccordionItems[0].ATag.Click()) is clicked and test is terminated. |
…e by using Link control for accessing to <a> in AccordionsPage.cs
|
Thank you. I will review tomorrow. |
…Navbar`1.cs) back to previous states
|
I wonder these parts. I tried to find the following element from ListGroups.html, line 97 from this group by these finding codes in ListGroupPage.cs, but they didn't work, but I don't figure out the reason. I assume that the code that I wrote may need the implementation which deals with dynamical changes of active or disable. Is it right? |
|
…g with searching by XPath, searching class marked with 'active' or 'disabled'
|
Thank you for the guide. I could learn valuable things by your comment. It was not easy to figure out how to apply XPath grammar fluently to search element. So, I tried to use XPath Helper chrome plugin. I tried to use it to check if my XPath statements would work well in real time, and I figured out that plugin could generate a specific XPath automatically when I'd mouse over a specific element on the web page with holding shift key. |
|
I added and edited some functionalities. |
|
Hi, For generic components you should not use such XPath parts: "@data-parent='#accordion'". Id is specific parameter and can definitely vary. Accordion is quite complex control, leave it please, I will try to handle Collapse and Accordion controls myself. Also I want to ask you to remove from this pull request all files related to Collapse, Accordion and Carousel. Let's keep one pull request for one feature (single component or pair of associated components). Let's have this PR for |
…ated to ListGroup, ListGroupItem.
|
Cleaned files related to Collapse, Accordion and Carousel. And made files related to BSListGroup and BSListGroupItem stay. Okay, after merge, I'll try to sync this with master. |
|
Thanks. I made some corrections to your pull request 96e064c. But I went wrong way and did it via branch pr/3. Then merged the branch to master with squash commit 55348ef. So the changes of your PR are merged with mine corrections and are on master. I am just closing this PR. Thanks again for your contribution. |
|
Thanks for accepting my implementations. I'll review the corrections. No problem. I'll try to do more. |
|
I tried to sync a fork to master, and it looks like all changes of master are reflected to my local repository. I followed these steps to sync my forked local repository to master.
I checked them again by repeating all the above steps, and I didn't get any errors. Like this : $ git checkout master $ git merge upstream/master |
|
Please try the following commands: These commands should completely reset your fork. |
|
Thank you. |
Looks like something is somewhat working. But not a good implementation. Hope you to refactor and show right implementations.