Allow Symfony 7 #1409
Merged
Allow Symfony 7 #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2023
Closed
Contributor
Author
Member
Nyholm
approved these changes
May 30, 2023
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Isn't the deprecation warnings from PHPUnit?
Member
It's triggered by PhpUnit because of our code: When we call The method $result->getStackEvents() is a generator https://github.com/async-aws/aws/blob/11379d8d430fe0f938e9832f092b329aa966cfa1/src/Service/CloudFormation/src/Result/DescribeStackEventsOutput.php#LL52C14-L52C14Which is no more allowed https://github.com/sebastianbergmann/phpunit/blob/46739478930289fa955fe4697688bae921a2674a/src/Framework/Assert.php#L236-L238 |
Contributor
Author
|
Deprecations fixed, CI green. |
Member
|
thanks ❤️ |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
May 30, 2023
This PR was merged into the 7.0 branch. Discussion ---------- [7.0] Remove hacks that made the CI green | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follows #50404 The Windows build is blocked by ext-redis and ext-apcu not being available as DLL for PHP 8.2. /cc `@weltling` 🙏 It's time to allow Symfony 7 again :) - [x] composer/composer#11474 - [x] async-aws/aws#1409 - [x] doctrine/orm#10724 - [x] [FriendsOfPHP/proxy-manager-lts](FriendsOfPHP/proxy-manager-lts@d93bd79) - [x] symfony/security-acl#111 - [x] tijsverkoyen/CssToInlineStyles#243 We also need a sigchild-enabled PHP, which `@derrabus` knows how to build :) Commits ------- 6dd126a [7.0] Remove hacks that made the CI green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.