Repository navigation
Issue 644 - #645
Merged
Merged
Issue 644#645
Conversation
Member
|
let's also use a more self-explanatory title in additional to the issue number |
hunterhector
left a comment
hunterhector
left a comment
Member
There was a problem hiding this comment.
overall looks fine, some small glitches
List is invariant so we have to update the function return type annotation a bit: python/mypy#3351
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
==========================================
- Coverage 80.77% 80.77% -0.01%
==========================================
Files 240 240
Lines 17153 17152 -1
==========================================
- Hits 13856 13855 -1
Misses 3297 3297
Continue to review full report at Codecov.
|
hunterhector
approved these changes
Feb 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #644.
Description of changes
Change the type_id in
data_listrepresentation of DataStore from integer to string of the fully qualified type name.Possible influences of this PR.
Describe what are the possible side-effects of the code change.
Test Conducted
Passed all original tests of DataStore.