Skip to content

Commit 042d9af

Browse files
Merge pull request #6 from apache/master
Merging
2 parents f5b0805 + 0d157ae commit 042d9af

File tree

71 files changed

+2447
-1166
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+2447
-1166
lines changed

CONTRIBUTING.md

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,29 @@ You can also use this small bookmarklet tool to fill your Pull Request fields au
3939
javascript:(function() {var e = document.getElementById('pull_request_body');if (e) {e.value += '### What is this PR for?\nA few sentences describing the overall goals of the pull request\'s commits.\n\n### What type of PR is it?\n[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]\n\n### Todos\n* [ ] - Task\n\n### Is there a relevant Jira issue?\n\n### How should this be tested?\nOutline the steps to test the PR here.\n\n### Screenshots (if appropriate)\n\n### Questions:\n* Does the licenses files need update?\n* Is there breaking changes for older versions?\n* Does this needs documentation?';}})();
4040
```
4141

42+
## Testing a Pull Request
43+
You can also test and review a particular Pull Request. Here are two useful ways.
44+
45+
* Using a utility provided from Zeppelin.
46+
47+
```
48+
dev/test_zeppelin_pr.py [# of PR]
49+
```
50+
51+
For example, if you want to test `#513`, then the command will be:
52+
53+
```
54+
dev/test_zeppelin_pr.py 513
55+
```
56+
57+
* Another way is using [github/hub](https://github.com/github/hub).
58+
59+
```
60+
hub checkout https://github.com/apache/incubator-zeppelin/pull/[# of PR]
61+
```
62+
63+
The above two methods will help you test and review Pull Requests.
64+
4265
## Source Control Workflow
4366
Zeppelin follows [Fork & Pull] (https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Development-workflow-with-Git:-Fork,-Branching,-Commits,-and-Pull-Request) model.
4467
@@ -53,7 +76,6 @@ When a Pull Request is submitted, it is being merged or rejected by following re
5376
* Committer can initiate lazy consensus ("Merge if there is no more discussion") and the code can be merged after certain time (normally 24 hours) when there is no review exists.
5477
* Contributor can ping reviewers (including committer) by commenting 'Ready to review' or suitable indication.
5578
56-
5779
## Becoming a Committer
5880
5981
The PPMC adds new committers from the active contributors, based on their contribution to Zeppelin. The qualifications for new committers include:

0 commit comments

Comments
 (0)