Repository navigation
Add a new confv3 with astropy-unified theme - #94
Conversation
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
I think generally we want to support old versions as much as possible because downstream package using this might not have resources to constantly update. A lot of them got sphinx-astropy dependency from our old astropy package template.
As long as @bsipocz is happy with the bumps, I am too.
Thanks!
| extras = | ||
| tests | ||
| v2deps: confv2 | ||
| v3deps: confv3 |
There was a problem hiding this comment.
Should add v3deps in env list above?
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
I'm not against dropping old python/sphinx versions, but given this is a low level infra package we should not go too crazy with it.
If it were me, I would drop at EOL and bump to the versions that added support for the next oldest version.
If there is a feature that you want to/need to use then dropping the old versions should be fine, but I don't think we should do that just for the sake of dropping. Not a strongly held opinion, so do let me know if you have arguments besides 1-2 fewer CI jobs.
OTOH, changes here look good, I commit the two fixes that are needed, the rest can go in when you all see fit.
| description = "Sphinx extensions and configuration specific to the Astropy project" | ||
| readme = {file = "README.rst", content-type = "text/x-rst"} | ||
| requires-python = ">=3.9" | ||
| requires-python = ">=3.10" |
There was a problem hiding this comment.
Yes, I think we should keep this and only from EOL. But it's not a strong preference as most packages doesn't really need the ability to build docs on their oldest supported version.
| python-version: "3.13" | ||
| toxenv: py313-test-v2deps-sphinxdev | ||
| python-version: "3.14" | ||
| toxenv: py314-test-v2deps-sphinxdev |
There was a problem hiding this comment.
please do add a v3 devdeps/sphinxdev job, too. Right now they are the same I think, but that may change.
Co-authored-by: Brigitta Sipőcz <[email protected]>
|
ok, I think this is ready to go and would unblock rolling this theme out to all the coordinated packages. |
What's our Python and Sphinx version compatibility policy here? We are running some very old sphinx!