Updating minimum sphinx verison to 1.6 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test failure with sphinx dev is unrelated to changes in this PR. |
Member
Author
|
@astrofrog - what do you think, should we include this update in astropy_helpers 2.0.10 or not? If yes, please tag a new sphinx-astropy release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new numpydoc release (v0.9.0) out we should also need to update the minimum required sphinx version to 1.6 otherwise we'll end up in build errors: https://circleci.com/gh/astropy/sphinx-astropy/56
(This came up originally in astropy_helpers where the dependencies are installed automatically as eggs so there is no easy way to control the versions).
If we decide to merge this PR rather than hack around to keep supporting older versions, then we need to make a new
sphinx-astropyrelease, too that will be a minimum requirement for astropy-helpers.