Skip to content

Update sphinx configuration to use new astropy-unified theme - #1328

Merged
rosteen merged 1 commit into
astropy:mainfrom
Cadair:sphinx-theme
May 15, 2026
Merged

Update sphinx configuration to use new astropy-unified theme#1328
rosteen merged 1 commit into
astropy:mainfrom
Cadair:sphinx-theme

Conversation

@Cadair

@Cadair Cadair commented May 12, 2026

Copy link
Copy Markdown
Member

This PR migrates this repo to use the new astropy-unified sphinx theme.

For more information about this project see astropy/astropy-project#522

@Cadair
Cadair requested review from eteq, keflavich and rosteen as code owners May 12, 2026 13:42
@Cadair Cadair mentioned this pull request May 12, 2026
Open
10 tasks done
@astrofrog

astrofrog commented May 12, 2026

Copy link
Copy Markdown
Member

Why does it keep trying to deploy to PyPI?

@Cadair

Cadair commented May 13, 2026

Copy link
Copy Markdown
Member Author

Why does it keep trying to deploy to PyPI?

Because this job with an environment runs on PRs: https://github.com/astropy/specutils/blob/main/.github/workflows/publish.yml#L21 it doesn't actually upload though. Github supports disabling deployments for environments now: https://github.blog/changelog/2026-03-19-github-actions-late-march-2026-updates/#github-actions-now-allows-developers-to-use-environments-without-auto-deployment

@rosteen

rosteen commented May 15, 2026

Copy link
Copy Markdown
Contributor

Why does it keep trying to deploy to PyPI?

Because this job with an environment runs on PRs: https://github.com/astropy/specutils/blob/main/.github/workflows/publish.yml#L21 it doesn't actually upload though. Github supports disabling deployments for environments now: https://github.blog/changelog/2026-03-19-github-actions-late-march-2026-updates/#github-actions-now-allows-developers-to-use-environments-without-auto-deployment

Hm, but why is it failing here? It succeeded on #1330.

Edit: Ah, looks like it was some transient timeouts. Rerunning to confirm.

rosteen
rosteen approved these changes May 15, 2026
View reviewed changes

@rosteen rosteen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new theme looks nice, thanks!

@rosteen rosteen added the no-changelog-entry-needed changelog bot directive label May 15, 2026
@rosteen rosteen added this to the 2.4.0 milestone May 15, 2026
@rosteen

rosteen commented May 15, 2026

Copy link
Copy Markdown
Contributor

CI failures are remote timeouts, merging.

@rosteen
rosteen merged commit ceecae5 into astropy:main May 15, 2026
12 of 16 checks passed

This branch was previously deployed

1 inactive deployment
pypi — 9dc7ea8b Deployed May 15, 2026 by Cadair via Build and publish Python 🐍 distributions 📦 to PyPI #192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rosteen rosteen rosteen approved these changes
@eteq eteq Awaiting requested review from eteq eteq is a code owner
@keflavich keflavich Awaiting requested review from keflavich keflavich is a code owner

Assignees

No one assigned

Labels

no-changelog-entry-needed changelog bot directive

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Cadair @astrofrog @rosteen