Remotedata rst handler #5

Activity

1. astrofrog commented on Oct 1, 2017

   

   astrofrog

   on Oct 1, 2017

   Member

   More actions

   I might be misunderstanding, but does this not already exist?

   http://docs.astropy.org/en/stable/development/testguide.html?highlight=REMOTE_DATA#working-with-data-files

   specifically:

   >>> datafile = get_data_filename('hash/94935')  # doctest: +REMOTE_DATA

   this works in docstrings and in rst files.
2. MSeifert04 commented on Oct 1, 2017

   

   MSeifert04

   on Oct 1, 2017

   ContributorAuthor

   More actions

   Ah, I haven't seen that one. I was actually thinking of something like this:

   .. skip-no_remote::
      >>> code that does something with remote-data
      >>> more code that relies on the remote-data access earlier.
   

   But +REMOTE_DATA would also work, it's just more verbose.
3. bsipocz commented on Oct 1, 2017

   

   bsipocz

   on Oct 1, 2017

   Last edited by bsipocz

   Member

   More actions

   afaik we don't yet have a directive that would work for a block of doctest, either for remote-data or for float_cmp, they would be nice to have additions though.

   Here are the related issues: astropy/astropy#2662 and astropy/astropy#2830

   👍React with 👍1Reacted by Michael Seifert
4. astrofrog commented on Oct 1, 2017

   

   astrofrog

   on Oct 1, 2017

   Member

   More actions

   Ah yes that would be cool!
5. drdavella commented on Oct 2, 2017

   

   drdavella

   on Oct 2, 2017

   Contributor

   More actions

   I think these probably actually belong in https://github.com/astropy/pytest-doctestplus, although any directive dealing with remote data will introduce a dependency on this plugin.

   😕React with 😕1Reacted by Michael Seifert
6. bsipocz commented on Oct 2, 2017

   

   bsipocz

   on Oct 2, 2017

   Member

   More actions

   all of these will be part of pytest-astropy, so cross dependency shouldn't be a problem I think.
7. drdavella commented on Oct 2, 2017

   

   drdavella

   on Oct 2, 2017

   Last edited by drdavella

   Contributor

   More actions

   @bsipocz while that is true, the main motivation for breaking these into separate plugins packages is to make them available to packages a la carte, right? In any case it shouldn't be a big deal because it can just be an optional dependency.

   My main point is that anything that defines a new doctest directive doesn't belong here: it belongs in pytest-doctestplus.
8. astrofrog commented on Oct 2, 2017

   

   astrofrog

   on Oct 2, 2017

   Member

   More actions

   I agree that this belongs in doctestplus, with a dependency on this package
9. MSeifert04 commented on Oct 2, 2017

   

   MSeifert04

   on Oct 2, 2017

   ContributorAuthor

   More actions

   will you open an issue there or should I?
10. drdavella commented on Oct 2, 2017

    

    drdavella

    on Oct 2, 2017

    Contributor

    More actions

    I created two new issues there and will close this one:
    scientific-python/pytest-doctestplus#2
    scientific-python/pytest-doctestplus#3

    👍React with 👍1Reacted by Michael Seifert
11. drdavella

    closed this as completedon Oct 2, 2017
12. MSeifert04 commented on Oct 2, 2017

    

    MSeifert04

    on Oct 2, 2017

    ContributorAuthor

    More actions

    Thanks @drdavella