Skip to content

Either fix internet_off or add a new decorator to disable internet #17

Open

Description

@drdavella

Currently the internet_off decorator indicates that a test will only run if --remote-data is not provided or --remote-data=none. It would be more useful to have a decorator that actually disables network access for the scope of that test.

To accomplish this we could either update internet_off, or we could add a new decorator (maybe disable_internet). As far as I know, no one is using internet_off yet, so we probably don't have to worry about API breakage.

Activity

  1. self-assigned this
    on Nov 7, 2017
  2. drdavella commented on Nov 8, 2017

    @drdavella
    ContributorAuthor

    It will be necessary to update the astropy testing documentation if/when this change is made.

  3. pllim commented on Apr 8, 2020

    @pllim
    Member

    This doesn't behave as expected in pytest 5.3 either. Works when I run it manually in interpreter but not when I invoke the test with pytest testfile. 🤷‍♀

    with no_internet():
        something_that_downloads()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions