Skip to content

Remove references to pyfits and pywcs - #47

Merged
astrofrog merged 4 commits into
astropy:masterfrom
sargas:remove-old-libs
Nov 2, 2014
Merged

astrofrog merged 4 commits into
astropy:masterfrom
sargas:remove-old-libs

Conversation

@sargas

@sargas sargas commented Oct 30, 2014

Copy link
Copy Markdown
Contributor

It looks like only pyfits.Header and pywcs.WCS were used and easily replaced. Some of the code using the astropy.io.fits.Card interface was removed, mostly in the examples.

@astrofrog

Copy link
Copy Markdown
Member

@sargas - great, thanks for the pull request! You can also try and uncomment the 'deprecations as exceptions' line in conftest.py and add that to this PR since if all tests pass with that option, we should leave it on to catch any future issues. Thanks!

@sargas

sargas commented Oct 30, 2014

Copy link
Copy Markdown
Contributor Author

Sure, thanks. All tests are passing for me with that option on master already; however, I'm not sure how much of that is a problem with the coverage of the tests, however.

@astrofrog

Copy link
Copy Markdown
Member

@sargas - ok, thanks! I'll leave this open for a day or so in case @leejjoon has any comments on it.

@cdeil

cdeil commented Nov 1, 2014

Copy link
Copy Markdown
Member

👍

@bsipocz bsipocz mentioned this pull request Nov 2, 2014
@astrofrog

Copy link
Copy Markdown
Member

Ok, I'll go ahead and merge this!

astrofrog added a commit that referenced this pull request Nov 2, 2014
Remove references to pyfits and pywcs
@astrofrog
astrofrog merged commit d12cefa into astropy:master Nov 2, 2014
@sargas
sargas deleted the remove-old-libs branch November 2, 2014 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants