Repository navigation
Conversation
also, vectors can be read now (not ignored as comments)
Contributor
Author
|
I rebased this so it should actually be mergeable and sensible |
Contributor
|
@keflavich : can you point me how ds9 define these region shapes? I thought they are defined with leading "#". And that is why I put these definition in the attribute parser. |
Contributor
There was a problem hiding this comment.
I am not comfortable with this try and except clause. It will consider "# circle(...)" as a real region, which I don't think is a good idea.
Contributor
Author
|
Ah, I see now - this PR is out of date, then! I agree that just stripping out "#" is a bad idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix: read region files without comments
Features: capability of reading projection, vector, and segment region types