Repository navigation
Add changelog entries from PR #100 - #104
Merged
Merged
Conversation
Member
|
👍 |
sargas
changed the title
Contributor
Author
|
I managed to change the API in another way that's undocumented: This is because angles are defined based on the rotation of the north axis onto the pixel plane, as measured by the center of the FITS image. It would make more sense to me to make it at the center of the shape in question, or even based on CRPIX[12], but this is how DS9 does it. Added the documentation update to this PR. |
Member
|
@sargas - Why wasn't this merged? Is it ready to go? (if yes, just go ahead and merge, please) |
bsipocz
reviewed
May 9, 2017
| w = WCS(f[0].header) | ||
| w_im = w.celestial | ||
| r2 = pyregion.parse(region_string).as_imagecoord(w_im) | ||
| `ShapeList.as_imagecoord <pyregion.ShapeList.as_imagecoord>` will use the |
Member
There was a problem hiding this comment.
I'm not sure this will be properly rendered, but suggest to merge now and follow-up with a fix if needed.
Member
|
I take the blame, and push the button now... |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to note the changes that #97 would have done, and warn about changing science results.