Skip to content

Adding np 1.11 to the travis matrix - #503

Merged
bsipocz merged 4 commits into
astropy:masterfrom
bsipocz:travis_add_numpy111
Feb 22, 2017
Merged

bsipocz merged 4 commits into
astropy:masterfrom
bsipocz:travis_add_numpy111

Conversation

@bsipocz

@bsipocz bsipocz commented Feb 15, 2017

Copy link
Copy Markdown
Member

as the latest stable is 1.12

@larrybradley - What do you think about dropping np1.7 at some point?

@bsipocz bsipocz added no-changelog-entry-needed No CHANGES.rst entry required (read by the changelog check) testing Test-only changes, or changes to the test configuration or CI test workflows labels Feb 15, 2017
@bsipocz bsipocz added this to the 0.3.1 milestone Feb 15, 2017
@larrybradley

Copy link
Copy Markdown
Member

@bsipocz That sounds good to me! Astropy should probably drop np 1.7 too.

@bsipocz

bsipocz commented Feb 15, 2017

Copy link
Copy Markdown
Member Author

Great, I'll drop it here then. Should I mention it in the changelog? While it may work in the future, we can't really guarantee it.

I'm also fixing the LTS issues.

@larrybradley

larrybradley commented Feb 15, 2017 •

Copy link
Copy Markdown
Member

@bsipocz

bsipocz commented Feb 15, 2017

Copy link
Copy Markdown
Member Author

should it be 0.4, or can we do that in 0.3.1?

@larrybradley

Copy link
Copy Markdown
Member

I think 0.3.1 is fine. It's not a new feature.

@bsipocz
bsipocz force-pushed the travis_add_numpy111 branch from f67bf67 to de2a6cf Compare February 15, 2017 20:17
@bsipocz

bsipocz commented Feb 17, 2017

Copy link
Copy Markdown
Member Author

@larrybradley @astrofrog - Is it normal that the circleci build picks up numpy 1.8 and astropy 1.2.1? According to the docker image, it should be pip installing astropy, so I assume that should pick up astropy 1.3?

@larrybradley

Copy link
Copy Markdown
Member

@bsipocz The docker images that get pulled are static (they don't get continuously built from the Dockerfile). They need to be manually rebuilt and pushed to Docker Hub. I can rebuild them locally (and indeed astropy 1.3 is now installed), but I don't have permission to push them up to the astropy docker hub account. @astrofrog will need to do that or give me permission.

@bsipocz
bsipocz force-pushed the travis_add_numpy111 branch 2 times, most recently from 3db80b1 to 183f44f Compare February 21, 2017 17:24
@bsipocz
bsipocz force-pushed the travis_add_numpy111 branch from 183f44f to 34662a2 Compare February 21, 2017 17:33
@bsipocz
bsipocz merged commit 3fe3ecd into astropy:master Feb 22, 2017
larrybradley pushed a commit that referenced this pull request Mar 1, 2017
Adding np 1.11 to the travis matrix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed No CHANGES.rst entry required (read by the changelog check) testing Test-only changes, or changes to the test configuration or CI test workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants