Repository navigation
Add imageutils as a dependency for photutils - #123
Merged
Merged
Conversation
This was referenced Jul 29, 2014
Member
|
👍 |
Member
Author
|
I think this is non-controversial ... let's do it. |
cdeil
added a commit
that referenced
this pull request
Jul 30, 2014
Add imageutils as a dependency for photutils
Member
|
I'll move the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest we make https://github.com/astropy/imageutils a required dependency for photutils.
This will allow us to move the image utils functions we have in photutils/utils to
imageutilsand simply import it inphotutilswithout having to do the optional import dance.The plan is to propose
imageutilsto be moved into the Astropy core in a month or two, so I don't see any issue with temporarily depending on this package.@astrofrog @eteq @larrybradley OK?