Skip to content

mask not used in PSFPhotometry #144

Closed

Description

@hamogu

I wanted to use the mask feature to mask out some missing values in my image due to saturated pixels. There should be enough information in the surrounding pixels to do PSF fit, however, I discovered that psf_photometry accepts as mask keyword, but never uses it in the code:
https://github.com/astropy/photutils/blob/master/photutils/psf.py#L327

Is that a bug or a feature to be implemented in the future (in that case is should probably raise a NotImplementedError for now...)?

Activity

  1. added this to the 0.2 milestone on Aug 27, 2014
  2. cdeil commented on Aug 27, 2014

    @cdeil
    Member

    The PSF photometry code is unfinished ... see open issues here:
    https://github.com/astropy/photutils/issues?q=is%3Aopen+is%3Aissue+label%3Apsf
    @hamogu As far as I know no-one is actively working on it, so if you have bandwidth to finish the implementation or add tests / docs, please do.

  3. hamogu commented on Sep 5, 2014

    @hamogu
    MemberAuthor

    #159 is one possible implementation that coud solve this.

  4. removed this from the 0.2 milestone on Apr 29, 2015
  5. added 2 commits that reference this issue on Feb 18, 2016
    80d72d4
    4d30617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething is broken or gives incorrect resultspsfphotutils.psf subpackage

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions