Skip to content
This repository was archived by the owner on Aug 11, 2023. It is now read-only.

Updates for new configuration system - #57

Closed
astrofrog wants to merge 1 commit into
astropy:masterfrom
astrofrog:update-config
Closed

astrofrog wants to merge 1 commit into
astropy:masterfrom
astrofrog:update-config

Conversation

@astrofrog

Copy link
Copy Markdown
Member

Extracted from #51.

@mdboom - is this the correct approach? What is the correct thing to do for packages that don't have any configuration items, if they want to avoid any warnings?

I guess the README.rst should be update to give instructions on what to do with the default config file that is here.

@astrofrog astrofrog mentioned this pull request May 18, 2014
@mdboom

mdboom commented May 19, 2014

Copy link
Copy Markdown
Contributor

This is the correct approach, but it requires astropy 0.4 as a minimum. I had intended to not make this change until 0.4 + 1 was out, since the old 0.3 approach will still work.

@astrofrog

Copy link
Copy Markdown
Member Author

@mdboom - ok, that makes sense!

@pllim

pllim commented May 22, 2014

Copy link
Copy Markdown
Member

Yes, I am working on an affiliated package that has no desire to be compatible with astropy 0.3. Sorry for the confusion.

@cdeil

cdeil commented Dec 11, 2014

Copy link
Copy Markdown
Member

Has this been implemented by #51 or should this still be merged?

@astrofrog

Copy link
Copy Markdown
Member Author

@cdeil - #51 was closed without merging and this PR is a spinoff from there. As indicated by @mdboom, we should do this close to the 1.0 release since the old way still works in the 0.4 series of Astropy.

@cdeil

cdeil commented Jan 21, 2015

Copy link
Copy Markdown
Member

@astrofrog - Can you rebase this?

@astrofrog

Copy link
Copy Markdown
Member Author

@mdboom - now that 1.0 is out, shall we go ahead and make the changes? I think supporting 0.4+ now is fine for affiliated packages?

@astrofrog

Copy link
Copy Markdown
Member Author

So I think the actual change to _astropy_init.py was made by @mdboom in 74f4799 - I will now rebase to just add the example, in case people want to include it.

@astrofrog

Copy link
Copy Markdown
Member Author

@cdeil @pllim - rebased

@pllim

pllim commented Oct 5, 2015

Copy link
Copy Markdown
Member

Not sure why I'm listed as one of the commit authors. But the PR looks good. Thanks!

@astrofrog

Copy link
Copy Markdown
Member Author

@pllim - you made this original PR ages ago, and this is a rebased version of that :)

@astrofrog

Copy link
Copy Markdown
Member Author

This also will need some updates to the docs about setting up an affiliated package to remind people to remove the config file if not needed.

@pllim

pllim commented Apr 11, 2016

Copy link
Copy Markdown
Member

@astrofrog -- 👍 to this

@bsipocz

bsipocz commented Apr 30, 2018

Copy link
Copy Markdown
Member

We're moving over to cookicutter, so I'm closing old unresolved PRs. Please reopen against the cookicutter branch if you feel this is still relevant.

@bsipocz bsipocz closed this Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants