Repository navigation
Conversation
|
This is the correct approach, but it requires astropy 0.4 as a minimum. I had intended to not make this change until 0.4 + 1 was out, since the old 0.3 approach will still work. |
|
@mdboom - ok, that makes sense! |
|
Yes, I am working on an affiliated package that has no desire to be compatible with astropy 0.3. Sorry for the confusion. |
|
Has this been implemented by #51 or should this still be merged? |
|
@astrofrog - Can you rebase this? |
|
@mdboom - now that 1.0 is out, shall we go ahead and make the changes? I think supporting 0.4+ now is fine for affiliated packages? |
4345d6b to
df11254
Compare
df11254 to
008446d
Compare
|
Not sure why I'm listed as one of the commit authors. But the PR looks good. Thanks! |
|
@pllim - you made this original PR ages ago, and this is a rebased version of that :) |
008446d to
5c36b7c
Compare
|
This also will need some updates to the docs about setting up an affiliated package to remind people to remove the config file if not needed. |
|
@astrofrog -- 👍 to this |
|
We're moving over to cookicutter, so I'm closing old unresolved PRs. Please reopen against the cookicutter branch if you feel this is still relevant. |
Extracted from #51.
@mdboom - is this the correct approach? What is the correct thing to do for packages that don't have any configuration items, if they want to avoid any warnings?
I guess the
README.rstshould be update to give instructions on what to do with the default config file that is here.