Repository navigation
Conversation
|
@Cadair Thanks! I tried this for gammapy (gammapy/gammapy#83) and it fails for https://travis-ci.org/gammapy/gammapy/builds/19280515 Should we extend the package-template with some function using the optional |
|
Are the builds that are failing ones that use old versions of NumPy?
|
No. It's the ones that are using the development version of astropy: |
|
OK, I am a little confused here now, as it looks like there is a |
|
@Cadair @cdeil - I haven't looked through the logs in detail, but I think I can guess what is going on. If you build a scipy wheel using numpy 1.7.1, it won't work when you then install a numpy 1.5 wheel because the ABI is different. The solution is to basically build every version of modules that depend on numpy (scipy and astropy) once for every major version of numpy. That means we need e.g. Does this make sense? |
|
@Cadair - you could consider making one travis job per numpy/python version combination to handle this. That is, if you cover 3 numpy versions and 4 python versions, you'd have 12 jobs. Each job would then produce all the wheels for each python/numpy combination. |
|
@astrofrog Yes, that is a problem and something that isn't really addressed by pip/wheels. I am not sure I have time time or the know-how to come up with a sane way of dealing with this. I think that if you want to deal with more complex numpy/scipy pairs for now you might have to build from source or build wheels. |
|
I think I can help this move forward, but have a few questions:
Looking at the main astropy repository it looks like tests there cover (table cells are the numpy version number unless otherwise indicated):
It looks like the coverage for an affiliated package in this pull request would be:
It isn't clear to me based on this what the target should be - numpy version from 1.5.1 to 1.8.0? against both astropy master and the latest stable? Or a subset? Should we be testing against combinations like astropy-0.3.x/numpy-1.8.0 that are not currently covered by the astropy/astropy tests?
then the setup of the travis file needs to change some, maybe like this: # omitted stuff
env:
global:
- PIP_WHEEL_COMMAND="pip install --use-wheel --use-mirrors"
# more omitted stuff....numpy version is set in matrix env
install:
- WHEEL_HOUSES="--find-links http://wheels.astropy.org/numpy-$NUMPY_VERSION --find-links http://wheels.astropy.org" # same for additional wheelhouses
- $PIP_WHEEL_COMMAND $WHEEL_HOUSES "numpy==$NUMPY_VERSION"
- $PIP_WHEEL_COMMAND $WHEEL_HOUSES "astropy"
I can build any wheels that are need and pass them on to either of the existing wheelhouses (I'm doing the builds on a local VM at the moment, but it would be easy enough to use travis, I suppose), and can take a shot at modifying I'm going to give something like this a try because I want to get a reasonably full set of travis tests running for ccdproc before writing a lot more code for it. So I could try something like this and report back, I suppose... |
|
I haven't attempted a Travis build in months because I've been waiting for this. When will this be done? |
|
Closed by #44 |
Fixes #24
ping @cdeil