Skip to content
This repository was archived by the owner on Aug 11, 2023. It is now read-only.

Updates to package template following updates to Astropy core - #30

Merged
astrofrog merged 6 commits into
astropy:masterfrom
astrofrog:update-setup-files
Oct 12, 2013
Merged

astrofrog merged 6 commits into
astropy:masterfrom
astrofrog:update-setup-files

Conversation

@astrofrog

Copy link
Copy Markdown
Member

A little delayed, but better late than never... Updates to the package template following @embray and @mdboom's improvements in the core package.

@astrofrog

Copy link
Copy Markdown
Member Author

Ah, hmm, this isn't going to work with Astropy 0.2 (the changes to setup.py). Will fix.

@astrofrog

Copy link
Copy Markdown
Member Author

@embray @mdboom - what do you think of the setup.py? I've set it up in a way that packages that decide to not be compatible with Astropy 0.2 can just get rid of a big chunk of code in the except.

@mdboom

mdboom commented Oct 2, 2013

Copy link
Copy Markdown
Contributor

Looks fine to me.

@astrofrog astrofrog mentioned this pull request Oct 6, 2013
@astrofrog

Copy link
Copy Markdown
Member Author

@embray - can we merge at least these changes for now? Some of the affiliated packages don't work with the latest Astropy version, so these changes would at least provide a fix for now.

@embray

embray commented Oct 11, 2013

Copy link
Copy Markdown
Member

Up to you I guess--I've got no skin in this.

astrofrog added a commit that referenced this pull request Oct 12, 2013
Updates to package template following updates to Astropy core
@astrofrog
astrofrog merged commit c91de52 into astropy:master Oct 12, 2013
@astrofrog

Copy link
Copy Markdown
Member Author

Damn, 9aa5339 was not meant to be included.

@astrofrog

Copy link
Copy Markdown
Member Author

Reverted in fc89028

@astrofrog

Copy link
Copy Markdown
Member Author

Just to be clear, I reverted the commit that was trying to make egg_info work since that was the aim of #32 which we didn't agree to merge.

@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 9aa5339 on astrofrog:update-setup-files into * on astropy:master*.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants